[Backport] [2.x] Reconsider the breaking changes check policy to detect breaking changes against released versions (#13292) #13310
Conversation
reta
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
|
@peternied funny enough, 2.x is already breaking API compatibility :( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #13310 +/- ##
============================================
- Coverage 71.28% 71.12% -0.16%
- Complexity 60145 60575 +430
============================================
Files 4957 5004 +47
Lines 282799 285424 +2625
Branches 41409 41730 +321
============================================
+ Hits 201591 203008 +1417
- Misses 64189 65252 +1063
- Partials 17019 17164 +145 ☔ View full report in Codecov by Sentry. |
…es against released versions (opensearch-project#13292) * Reconsider the breaking changes check policy to detect breaking changes against released versions Signed-off-by: Andriy Redko <[email protected]> * Add an ability to provide the target version to compare with for japicmp tasks Signed-off-by: Andriy Redko <[email protected]> * Add documentation for japicmp tasks Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit b4692c8) Signed-off-by: Andriy Redko <[email protected]>
reta
force-pushed
the
backport/backport-13292-to-2.x
branch
from
55cd29b
to
880f21f
Compare
What do you want to do about the breaking changes from 2.13 -> 2.14? It feels like we need a release blocking issue to identify and resolve what we accept vs revert 😵💫 |
I think some of them we could address in scope of #13308, for now I made a change to fallback to the current compatibility target (latest snapshot). |
|
❕ Gradle check result for 880f21f: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Backport of #13292 to
2.x